multi: Add label to PublishTransaction
#1411
Merged
+21
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ffranr
reviewed
Feb 25, 2025
|
I vote for: |
Pull Request Test Coverage Report for Build 14731819540Details
💛 - Coveralls |
|
Can we go with one of the above ideas so we can merge this? |
|
@gijswijs, remember to re-request review from reviewers when ready |
ffranr
force-pushed
the
publish-tx-label
branch
from
822bf44 to
c19e61d
Compare
I've gone with: I've also made the labels constants and rebased. |
guggero
approved these changes
Apr 29, 2025
github-project-automation
bot
moved this from 🏗 In progress
to 👀 In review
in Taproot-Assets Project Board
github-project-automation
bot
moved this from 👀 In review
to ✅ Done
in Taproot-Assets Project Board
github-merge-queue
bot
removed this pull request from the merge queue due to it being already merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR chanegs the label used for Txs published to the network. Before, all Txs got the label
tapd-asset-minting. Now, the label depends on the context. Currently we use two labels:tapd-asset-mintingtapd-asset-sendIn the future we could even allow for more granular information being passed to the label.